Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CRON field value 1/2 at position 2 #181

Open
wants to merge 178 commits into
base: master
Choose a base branch
from

Conversation

4meck
Copy link

@4meck 4meck commented Sep 1, 2021

dragonmantank\cron-expression (v3.1.0)

$expr = '0 0 1/2 * *';
$cron = \Cron\CronExpression::factory($expr);
echo $cron->getNextRunDate()->format('Y-m-d H:i:s');

InvalidArgumentException in C:\vendor\dragonmantank\cron-expression\src\Cron\CronExpression.phpat line 158
Invalid CRON field value 1/2 at position 2

mtdowling/cron-expression (v. 1.2.3) execute this code correct (w/o Exception)

dragonmantank and others added 30 commits October 12, 2017 11:59
if it can be null in the factory, the constructor should have it too

also added phpdoc stuff
fix symmetry in constructor and factory method
Fixed infinite loop when resolving last weekday of the month from literals
[dependencies] Improve dependency declaration
…einterface

Get timezone from DateTimeInterface
Add missing docblocks and normalize end of lines
highlight variables in `README`
nyamsprod and others added 30 commits January 14, 2022 10:33
PHP 8.2 deprecates `"${var}"` string interpolation pattern.
This fixes all three of such occurrences in `dragonmantank/cron-expression` package.

 - [PHP 8.2: `${var}` string interpolation deprecated](https://php.watch/versions/8.2/${var}-string-interpolation-deprecated)
 - [RFC](https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation)
As discussed in #133, the PHP 8.1's date extension daylight saving
APIs have been suffering with instabilities. Let's skip the affected
tests until php/php-src#9165 is resolved.

Signed-off-by: Athos Ribeiro <[email protected]>

Signed-off-by: Athos Ribeiro <[email protected]>
* #137 Add check for multiple question marks
* #137 Validate position of question marks in expression
Added "throws" docblock section, so it's immediately obvious in which way an invalid cron expression will fail

Co-authored-by: Roy Garrido <[email protected]>
Co-authored-by: Christopher Georg <[email protected]>
Co-authored-by: Chris Tankersley <[email protected]>
This duplicate was not added in alphabetical order and thus probably was missed
during PR merge.

see 6dda217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.